Add type hints to mocket.plugins.httpretty #290
Conversation
@mindflayer is this because I removed |
I think those are two different things:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #290 +/- ##
==========================================
+ Coverage 98.59% 98.70% +0.11%
==========================================
Files 22 22
Lines 994 1004 +10
==========================================
+ Hits 980 991 +11
+ Misses 14 13 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@mindflayer here's the status of both failing checks:
What do you suggest? |
For when this happens, the only possible solution is waiting and retry, which is what I've just done (it's now flagged as succeeded). I tried a bunch of similar services, and of course they do not work 100% of the times (which is the actual reason for Mocket to exist in the first place: to make CIs great again :) ). |
|
Added unit tests to get mocketize to make the coverage happy |
|
|
@mindflayer This should be ready to review. The CI is failing again due to httpbin |
|
I noticed that, which was the reason why I couldn't finish. I'm putting my
little daughter to bed and will try again soon.
…On Tue, 6 May 2025, 20:02 João Sousa, ***@***.***> wrote:
*JPDSousa* left a comment (mindflayer/python-mocket#290)
<#290 (comment)>
@mindflayer <https://github.com/mindflayer> This should be ready to
review. The CI is failing again due to httpbin
—
Reply to this email directly, view it on GitHub
<#290 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEAXXO5OO66ECL25OAC7OL25D2LDAVCNFSM6AAAAAB4QSXVD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQNJVGQ3DSOBUGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
See #203
While the type hints introduced are not that extensive, they do pass some basic mypy rules (e.g., disallow_untyped_decorators).
I used
tests.test_httprettyto test the type hints introduced. Again, while it's not an exhaustive approach, it provides some sanity check that types work as expected.